Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ErrorBoundary fallbackUI prop type definition #95

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

danfry1
Copy link
Contributor

@danfry1 danfry1 commented May 24, 2023

Description of the change

This updates the type definition for the ErrorBoundary's fallbackUI prop

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes #87

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@danfry1 danfry1 changed the title fix ErrorBoundary fallbackUI prop fix ErrorBoundary fallbackUI prop type definition May 24, 2023
@gazpachu
Copy link

Please, can we get this PR merged? 🙏

@gazpachu
Copy link

cc @rollbar-bborsits (Juanjo Marrón suggested to ping you) to have a look at this 🙏

@ghost
Copy link

ghost commented Jun 19, 2023

Hey @gazpachu, thank you for your PR. Let me find someone internally to look into it.

@ghost ghost assigned waltjones Jun 19, 2023
@gazpachu
Copy link

@rollbar-bborsits it's not my PR, but thanks for the prompt response 🙇

@ghost
Copy link

ghost commented Jun 20, 2023

@gazpachu You're right, I misspoken. Sorry about that. @danfry1 Thank you for the PR. We appreciate your efforts :)
In the meantime, I contacted @waltjones, who will take care of this soon.

@waltjones waltjones merged commit 12e260d into rollbar:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect typescript type on fallbackUI prop on ErrorBoundary
4 participants