Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ErrorBoundary fallbackUI prop type definition #95

Merged
merged 3 commits into from
Jun 20, 2023
Merged

fix ErrorBoundary fallbackUI prop type definition #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f06956
fix: fix ErrorBoundary fallbackUI prop
daniel-encord May 24, 2023
83c33e9
update type using ComponentType and use PropTypes.elementType for run…
daniel-encord May 24, 2023
eda9ead
use ComponentType import
daniel-encord May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, Context as ReactContext, ErrorInfo, ReactNode } from 'react';
import { Component, Context as ReactContext, ErrorInfo, ReactNode, ComponentType } from 'react';
import Rollbar, { Callback, Configuration } from 'rollbar';

export const LEVEL_DEBUG = 'debug';
Expand All @@ -16,7 +16,7 @@ export type LEVEL =
type Extra = Record<string | number, unknown>;
export interface ErrorBoundaryProps {
children: ReactNode;
fallbackUI?: ReactNode;
fallbackUI?: ComponentType<{ error: Error | null, resetError: () => void }>;
errorMessage?: string | (() => string);
extra?:
| Extra
Expand Down
2 changes: 1 addition & 1 deletion src/error-boundary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export class ErrorBoundary extends Component {
static contextType = Context;

static propTypes = {
fallbackUI: PropTypes.func,
fallbackUI: PropTypes.elementType,
errorMessage: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
extra: PropTypes.oneOfType([PropTypes.object, PropTypes.func]),
level: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
Expand Down