Fixes for TGeoTessellated and TGeoVGShape persistency. #14327
Conversation
The previous implementation required TGeoTessellated shapes to be read attached to a TGeoManager. This removes the limitation, and allows also reading geometry files containing shapes converted to VecGeom corresponding solids. Fixes #root-project#14283
|
Starting build on |
|
Build failed on ROOT-ubuntu2204/nortcxxmod. Failing tests: |
Test Results 9 files 9 suites 2d 1h 52m 26s ⏱️ For more details on these failures, see this check. Results for commit 8f531ea. |
|
The failed tests are unrelated |
…14327) The previous implementation required TGeoTessellated shapes to be read attached to a TGeoManager. This removes the limitation, and allows also reading geometry files containing shapes converted to VecGeom corresponding solids. Fixes #root-project#14283
The function is no longer implemented, see root-project#14327 Can lead to linking issues when undefined symbols are not ignored.
The function is no longer implemented, see #14327 Can lead to linking issues when undefined symbols are not ignored.
…14327) The previous implementation required TGeoTessellated shapes to be read attached to a TGeoManager. This removes the limitation, and allows also reading geometry files containing shapes converted to VecGeom corresponding solids. Fixes #root-project#14283
…ject#14339) The function is no longer implemented, see root-project#14327 Can lead to linking issues when undefined symbols are not ignored.
|
Hi @agheata , With this update, there is removed public function Would it be possible to restore this function ? Thank you. |
|
This is probably not as relevant as persistence was broken anyways, but since class members were added / removed (and hence, the schema and streamers have changed), I believe these changes do also require a class version bump, no? |
The previous implementation required TGeoTessellated shapes to be read attached to a TGeoManager. This removes the limitation, and allows also reading geometry files containing shapes converted to VecGeom corresponding solids.
This Pull request:
Changes or fixes:
TGeoFacethelper class, eliminating referencing vertices stored in the associatedTGeoTessellatedobject, since this required calling a specific methodTGeoTessellated::AfterStreamerto fix all the facet objects. The new version moves all vertex operations from TGeoFacet to the TGeoTessellated class, making the latter readable from a root file even if not connected to aTGeoManagerTGeoVGShapewhich interfacesTGeoShapetovecgeom::VPlacedVolume. This allows to write/read geometry files after being converted to VecGeom. Upon reading, a check is made that the current root version was also compiled with VecGeom support, and if this is not the case aFatalexception is fired.Checklist:
This PR fixes #14283