Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README: Clarify that enumeration_type is returned, not provider_type #64

Closed
frankfarach opened this issue Apr 9, 2022 · 0 comments
Closed

README: Clarify that enumeration_type is returned, not provider_type #64

frankfarach opened this issue Apr 9, 2022 · 0 comments
Assignees
@frankfarach
Labels
staged Issue is staged for merging
Milestone
rOpenSci Review

Comments

@frankfarach
Copy link
Collaborator

See ropensci/software-review#505 (comment):

Under "Search the registry" section the README mentions 4 regular vector columns that are returned by npi_search() but when I execute the code I get enumeration_type in place of the mentioned provider_type
@frankfarach frankfarach added this to the rOpenSci Review milestone Apr 9, 2022
@frankfarach frankfarach self-assigned this Apr 9, 2022
frankfarach added a commit that referenced this issue Apr 10, 2022
@frankfarach
Closes #50 and #64
4fdccf5
@frankfarach frankfarach added the staged Issue is staged for merging label Oct 23, 2022
frankfarach added a commit that referenced this issue Nov 9, 2022
@frankfarach @parmsam
Release v0.2.0 to GitHub (#77)
27d3faf 
* Feature/advanced uses vignette (#43)

* added intro to npi vignette

* auto updated DESCRIPTION file and git ignore

* updated based on review comments

* added advanced uses vignette

* adv use vignette updates

* added toc to both vignettes

* updated based on feedback

* added sentence on motivation for section

Co-authored-by: parmsam <parmsam>

* Closes #60

* Closes #56

* Closes #58

* Closes #63

* Closes #50 and #64

* Fix for warning about #63

* Closes #47

* Closes #48

* Closes #51

Some NPI records had multiple tibbles in the taxonomies list column of the results with FALSE for all values of the `primary` column. Hence, there was no record with a primary taxonomy. The fix here was to return the first row of the taxonomies tibble grouped by NPI. This removes the error by ensuring a 1-to-1 relationship between NPIs and taxonomy rows.

* Closes #57

* Closes #72

* Closes #52

* Closes #59

* Closes #53

* Closes #55

* Convert epoch to date to resolve response error (see #75)

* Motivate the use of npi_is_valid() (Closes #69)

* Closes #65

* Closes #70

* Closes #45

* Closes #66

* Closes #49

* Closes #67

* Fix typo in validating NPIs

* Closes #68

* Cover npi_flatten() with unit tests for #73

* Closes #73. Add guidance on npi_flatten() to README.

* Closes #54

* rOpenSci onboarding

* Clean up installation instructions

* Fix URL in test

* Prep for 0.2.0 release

* Update copyright metadata

* Update CITATION

Co-authored-by: Sam Parmar <40672605+parmsam@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankfarach frankfarach

Labels
staged Issue is staged for merging
Projects
None yet
Milestone
rOpenSci Review
Development

No branches or pull requests
1 participant
@frankfarach