-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kr210 kinematics update #124
Open
jwhendy
wants to merge
8
commits into
ros-industrial:melodic-devel
Choose a base branch
from
jwhendy:kr210_kinematics_update
base: melodic-devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a08e884
shot at correcting kr210l150 kinematics and adding kr210l150-2
jwhendy bf8cf1f
missed some added files
jwhendy 8824b8a
Merge branch 'indigo-devel' into kr210_kinematics_update
gavanderhoorn ff1b3d2
split L150 and L150-2 into separate xacro/launch files
jwhendy 0e8c463
unified KR210 and KR210-2 with a new arg, variant
jwhendy d756f43
moved variants macro.xacro into main file; updated test to take varia…
jwhendy bf6c255
must have omitted a git rm on launch files
jwhendy 7677311
was still including the _variants macro; removed
jwhendy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
<?xml version="1.0" ?> | ||
<launch> | ||
<param name="robot_description" command="$(find xacro)/xacro.py '$(find kuka_kr210_support)/urdf/kr210l150.xacro'" /> | ||
<arg name="variant" default="" /> | ||
<param name="robot_description" command="$(find xacro)/xacro --inorder '$(find kuka_kr210_support)/urdf/kr210l150.xacro' variant:=$(arg variant)" /> | ||
</launch> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+6.84 KB
(140%)
kuka_kr210_support/meshes/kr210l150/collision/base_link.stl
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
848 changes: 0 additions & 848 deletions
848
kuka_kr210_support/meshes/kr210l150/visual/base_link.dae
This file was deleted.
Oops, something went wrong.
Binary file not shown.
2,245 changes: 0 additions & 2,245 deletions
2,245
kuka_kr210_support/meshes/kr210l150/visual/link_1.dae
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
2,099 changes: 0 additions & 2,099 deletions
2,099
kuka_kr210_support/meshes/kr210l150/visual/link_6.dae
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
<?xml version="1.0" ?> | ||
<launch> | ||
<arg name="variant" default="" /> | ||
<group ns="load_kr210l150__"> | ||
<include file="$(find kuka_kr210_support)/launch/load_kr210l150.launch" pass_all_args="true"/> | ||
</group> | ||
|
||
<group ns="test_kr210l150__"> | ||
<include file="$(find kuka_kr210_support)/launch/test_kr210l150.launch" pass_all_args="true"/> | ||
</group> | ||
</launch> |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<?xml version="1.0" ?> | ||
<robot name="kuka_kr210" xmlns:xacro="http://wiki.ros.org/xacro"> | ||
<robot name="kuka_kr210l150" xmlns:xacro="http://wiki.ros.org/xacro"> | ||
<xacro:include filename="$(find kuka_kr210_support)/urdf/kr210l150_macro.xacro"/> | ||
<xacro:kuka_kr210l150 prefix=""/> | ||
</robot> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have a corresponding
kr210l150_2.xacro
file as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking not anymore? I apologize as I flopped back and forth on trying to use an argument, then quasi giving up and just making replicate macro/xacro, launch, and test files, then going back to an argument. So I figured the path was either:
_2
argument, and duplicate everything. The only difference would be the definition ofjoint_a3
per variant_2
argument, but don't replicate all the files with afoo_2.bar
shadow