Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kr210 kinematics update #124

Open
wants to merge 8 commits into
base: melodic-devel
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion kuka_kr210_support/launch/load_kr210l150.launch
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<?xml version="1.0" ?>
<launch>
<param name="robot_description" command="$(find xacro)/xacro.py '$(find kuka_kr210_support)/urdf/kr210l150.xacro'" />
<arg name="variant" default="" />
<param name="robot_description" command="$(find xacro)/xacro --inorder '$(find kuka_kr210_support)/urdf/kr210l150.xacro' variant:=$(arg variant)" />
</launch>
4 changes: 3 additions & 1 deletion kuka_kr210_support/launch/test_kr210l150.launch
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?xml version="1.0" ?>
<launch>
<include file="$(find kuka_kr210_support)/launch/load_kr210l150.launch" />
<arg name="variant" default="" />
<include file="$(find kuka_kr210_support)/launch/load_kr210l150.launch" pass_all_args="true" />
<node name="joint_state_publisher" pkg="joint_state_publisher" type="joint_state_publisher">
<param name="use_gui" value="true" />
</node>
Expand Down
Binary file modified kuka_kr210_support/meshes/kr210l150/collision/base_link.stl
Binary file not shown.
Binary file modified kuka_kr210_support/meshes/kr210l150/collision/link_1.stl
Binary file not shown.
Binary file modified kuka_kr210_support/meshes/kr210l150/collision/link_2.stl
Binary file not shown.
Binary file modified kuka_kr210_support/meshes/kr210l150/collision/link_3.stl
Binary file not shown.
Binary file modified kuka_kr210_support/meshes/kr210l150/collision/link_4.stl
Binary file not shown.
Binary file modified kuka_kr210_support/meshes/kr210l150/collision/link_5.stl
Binary file not shown.
Binary file modified kuka_kr210_support/meshes/kr210l150/collision/link_6.stl
Binary file not shown.
848 changes: 0 additions & 848 deletions kuka_kr210_support/meshes/kr210l150/visual/base_link.dae

This file was deleted.

Binary file not shown.
2,245 changes: 0 additions & 2,245 deletions kuka_kr210_support/meshes/kr210l150/visual/link_1.dae

This file was deleted.

Binary file not shown.
402 changes: 0 additions & 402 deletions kuka_kr210_support/meshes/kr210l150/visual/link_2.dae

This file was deleted.

Binary file not shown.
775 changes: 0 additions & 775 deletions kuka_kr210_support/meshes/kr210l150/visual/link_3.dae

This file was deleted.

Binary file not shown.
410 changes: 0 additions & 410 deletions kuka_kr210_support/meshes/kr210l150/visual/link_4.dae

This file was deleted.

Binary file not shown.
178 changes: 0 additions & 178 deletions kuka_kr210_support/meshes/kr210l150/visual/link_5.dae

This file was deleted.

Binary file not shown.
2,099 changes: 0 additions & 2,099 deletions kuka_kr210_support/meshes/kr210l150/visual/link_6.dae

This file was deleted.

Binary file not shown.
11 changes: 11 additions & 0 deletions kuka_kr210_support/test/roslaunch_test_kr210l150.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0" ?>
<launch>
<arg name="variant" default="" />
<group ns="load_kr210l150__">
<include file="$(find kuka_kr210_support)/launch/load_kr210l150.launch" pass_all_args="true"/>
</group>

<group ns="test_kr210l150__">
<include file="$(find kuka_kr210_support)/launch/test_kr210l150.launch" pass_all_args="true"/>
</group>
</launch>
217 changes: 0 additions & 217 deletions kuka_kr210_support/urdf/kr210l150.urdf

This file was deleted.

2 changes: 1 addition & 1 deletion kuka_kr210_support/urdf/kr210l150.xacro
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" ?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a corresponding kr210l150_2.xacro file as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking not anymore? I apologize as I flopped back and forth on trying to use an argument, then quasi giving up and just making replicate macro/xacro, launch, and test files, then going back to an argument. So I figured the path was either:

  • no _2 argument, and duplicate everything. The only difference would be the definition of joint_a3 per variant
  • use the _2 argument, but don't replicate all the files with a foo_2.bar shadow

<robot name="kuka_kr210" xmlns:xacro="http://wiki.ros.org/xacro">
<robot name="kuka_kr210l150" xmlns:xacro="http://wiki.ros.org/xacro">
<xacro:include filename="$(find kuka_kr210_support)/urdf/kr210l150_macro.xacro"/>
<xacro:kuka_kr210l150 prefix=""/>
</robot>
Loading