Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 compatibility for kuka_rsi_simulator under Noetic #217

Open
wants to merge 1 commit into
base: melodic-devel
Choose a base branch
from
Open

Python 3 compatibility for kuka_rsi_simulator under Noetic #217

wants to merge 1 commit into from

Conversation

aatb-ch
Copy link
Contributor

@aatb-ch aatb-ch commented Mar 29, 2022

the kuka_rsi_simulator needed a couple changes to run under Noetic, this is backward compatible with Python 2.7.

simonschmeisser
simonschmeisser approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@simonschmeisser simonschmeisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would be bigger changes, sorry for not looking at them for so long! For some bonus points you could change the commit message to something like "use python exception syntax supported since 2.6" or similar but I approve as is

@aatb-ch
Copy link
Contributor Author

aatb-ch commented Jan 9, 2023

thanks! regarding commit message, my bad yes, I wasn't expecting to create a PR and needed a quick fix but I must be more careful indeed, point taken!

@aatb-ch aatb-ch closed this Jan 9, 2023
@aatb-ch aatb-ch reopened this Jan 9, 2023
@simonschmeisser
Copy link
Collaborator

No worries! It can be changed quite easily after the fact (git commit --amend and then git push --force-with-lease) but we can also change it when merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonschmeisser simonschmeisser simonschmeisser approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aatb-ch @simonschmeisser