Fix issues when built or run on Windows #1466
Conversation
| @@ -59,7 +59,12 @@ def findCaller(self, dummy=False): # Dummy second arg to match Python3 function | |||
| f = inspect.currentframe() | |||
| if f is not None: | |||
| f = f.f_back | |||
| else: | |||
| return file_name, lineno, func_name | |||
There was a problem hiding this comment.
Can you please provide some context why this change was necesary? The same for the break a few lines below.
There was a problem hiding this comment.
without this, roscore won't run on Windows. I need to investigate more about this change, will revert it from this PR for now.
| const unsigned source_cnt = _sources.size(); | ||
| pollfd fds[source_cnt]; | ||
| XmlRpcSource * sources[source_cnt]; | ||
| unsigned source_cnt = _sources.size(); |
There was a problem hiding this comment.
Why can't this variable be const anymore?
There was a problem hiding this comment.
on MSVC compiler will complain that _sources.size() is not an constant, so I need to remove the const. I'll investigate to see if we can add it back
There was a problem hiding this comment.
after switching to use std::vector, I'm able to declare source_cnt as a const variable, will add it back.
|
Thank you for the patch. The failing test is known to be flaky so this could be merged. Do you want to keep iterating on this for the logging (if necessary?) or address that in a separate PR? |
|
I will do a separate PR for the change in logging. |
No description provided.