[roslaunch] Better exception handling when resource is not found. #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Aug 9, 2018
When `$(find pkg)` fail to return a resource in `arg` tag, `roslaunch` fails without printing useful output. With this PR it provides better explanation. Without this PR: ``` $ roslaunch /tmp/invalid_arg.launch : Invalid <arg> tag: foo ROS path [0]=/opt/ros/kinetic/share/ros ROS path [1]=/home/n130s/ROS/indigo_trusty/cws_rosdt/src/ros/ros_comm/tools/roslaunch ROS path [2]=/opt/ros/kinetic/share Arg xml is <arg default="$(find foo)/.config" name="foo"/> The traceback for the exception was written to the log file ``` With this PR: ``` $ roslaunch /tmp/invalid_arg.launch : Invalid <arg> tag: Make sure the following is found in ROS_PACKAGE_PATH: foo ROS path [0]=/opt/ros/kinetic/share/ros ROS path [1]=/home/n130s/ROS/indigo_trusty/cws_rosdt/src/ros/ros_comm/tools/roslaunch ROS path [2]=/opt/ros/kinetic/share Arg xml is <arg default="$(find foo)/.config" name="foo"/> The traceback for the exception was written to the log file ``` ``` $ more /tmp/invalid_arg.launch <?xml version="1.0"?> <launch> <arg name="foo" default="$(find foo)/.config" /> <arg name="baa" default="$(arg foo)/hoge.yaml" /> </launch> ```
130s
force-pushed
the
impr_invalid_arg_err/melodic-devel
branch
from
93ddea2 to
9aaf108
Compare
|
Output with the updated commit : |
|
@ros-pull-request-builder retest this please |
|
Thank you for the improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
$(find pkg)fail to return a resource inargtag,roslaunchfails without printing useful output. With this PR it provides better explanation.Though I haven't looked into whether there's a test that covers this yet, I'm happy to add one if needed.
Without this PR:
With this PR: