show connection info on rosnode info #1497
Conversation
maximest-pierre
changed the title
maximest-pierre
force-pushed
the
show_connection_info_in_rosnode_info
branch
from
4f76381 to
254e659
Compare
| @@ -62,6 +63,8 @@ | |||
|
|
|||
| NAME='rosnode' | |||
| ID = '/rosnode' | |||
| # Line is defined at clients/rospy/src/rospy/impl/tcpros_base.py at line 477 | |||
There was a problem hiding this comment.
Please do not refer to a line number since that is going to change if the file is being edited in the future. Instead refer to the file and a symbol, e.g. The string is defined in clients/rospy/src/rospy/impl/tcpros_base.py TCPROSTransport.get_transport_info.
| @@ -473,6 +473,7 @@ def get_transport_info(self): | |||
| Similar to getTransportInfo() in 'libros/transport/transport_tcp.cpp' | |||
| e.g. TCPROS connection on port 41374 to [127.0.0.1:40623 on socket 6] | |||
| """ | |||
| # Changing this line while break tools/rosnode/src/rosnode/__init__.py at line 67 | |||
There was a problem hiding this comment.
Please do not refer to a line number since that is going to change if the file is being edited in the future. Instead refer to the file and a symbol, e.g. Pattern matching this output in tools/rosnode/src/rosnode/__init__.py CONNECTION_PATTERN.
Also this line currently uses a tab which can't be mixed with space in Python 3. Please change it to use the spaces (as the rest of the file).
maximest-pierre
force-pushed
the
show_connection_info_in_rosnode_info
branch
from
254e659 to
db2f425
Compare
|
@dirk-thomas It should be good now |
|
Great, thank you for picking this up. For future PRs it would be good to keep the original commit in the author name. |
|
Thanks @maximest-pierre . Did you notice the |
|
@efernandez Not really. I just compared it with |
|
Then it should be fine @maximest-pierre . I probably have a laggy connection when I tried, or an overloaded system. 👍 |
Continuation of #1386
The only changes are to address the reviews