Fix memory error due to missing rosout_disable_topics_generation para… #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrrx
reviewed
Sep 21, 2018
jspricke
reviewed
Sep 21, 2018
| @@ -107,7 +108,9 @@ void ROSOutAppender::log(::ros::console::Level level, const char* str, const cha | |||
| // check parameter server/cache for omit_topics flag | |||
| // the same parameter is checked in rosout.py for the same purpose | |||
| if (!ros::param::getCached("/rosout_disable_topics_generation", disable_topics_)) | |||
| disable_topics_ = false; | |||
| { | |||
| disable_topics_ = false; | |||
There was a problem hiding this comment.
I guess we don't need this if the default is set in the initializer, right?
|
Generally not, but I left the check of the return value of |
… in favour of a class initialiser
jspricke
approved these changes
Sep 21, 2018
mgrrx
approved these changes
Sep 21, 2018
|
Thanks for the patch. |
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
ros#1507) * Fix memory error due to missing rosout_disable_topics_generation parameter * Initialise disable_topics_ in constructor of ROSOutAppender * Removed security check for rosout_disable_topics_generation parameter in favour of a class initialiser
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 3, 2020
#1507) * Fix memory error due to missing rosout_disable_topics_generation parameter * Initialise disable_topics_ in constructor of ROSOutAppender * Removed security check for rosout_disable_topics_generation parameter in favour of a class initialiser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the parameter
rosout_disable_topics_generationwas not secured by a default value and thus could cause a memory error if it is not set (cf. https://lists.debian.org/debian-science/2018/09/msg00046.html.