roslaunch: add an option in XmlLoader to only load arg tags #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes ros#1300. It's off/false by default, but it's used by `arg_dump` to stop roslaunch-autocomplete from failing if any arg has no default value.
christophebedard
force-pushed
the
fix-roslaunch-autocomplete
branch
from
72559a1 to
f2dcac9
Compare
christophebedard
changed the title
|
Not sure why it's failing or whether it has anything to do with this PR! |
|
@ros-pull-request-builder retest this please |
|
Thanks for the patch. |
|
@dirk-thomas my pleasure, although looking at it again I should've used |
|
I think it is ok for now. Hopefully it isn't being overlooked if something is added after all the conditional blocks in the future. If you feel strongly about it please feel free to create a PR for it. Should be trivial to review / merge. |
|
I ended up changing it (#1540) since I think it's more appropriate in this situation. Thank you for your time! |
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
This fixes ros#1300. It's off/false by default, but it's used by `arg_dump` to stop roslaunch-autocomplete from failing if any arg has no default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1300. It's off/false by default, but it's used by
arg_dumpto stoproslaunch-completefrom failing if any arg has no default value.