Removed nullptr access from Timer().hasStarted() #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird. The tests should not be failing |
|
This looks like a reasonable and safe fix, thanks! @ros-pull-request-builder retest this please |
|
Thanks for the fix. |
dirk-thomas
pushed a commit
that referenced
this pull request
Jan 31, 2019
* roscpp: copy hasStarted() member function from ros::Timer to ros::WallTimer and ros::SteadyTimer ros::Timer::hasStarted() has been added in #1464. The same member function should exist in the other two timer implementations, too, for completeness. * Check for nullptr in WallTimer::hasStarted() and SteadyTimer::hasStarted() Analogous to fe9479c (#1541).
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
* roscpp: copy hasStarted() member function from ros::Timer to ros::WallTimer and ros::SteadyTimer ros::Timer::hasStarted() has been added in ros#1464. The same member function should exist in the other two timer implementations, too, for completeness. * Check for nullptr in WallTimer::hasStarted() and SteadyTimer::hasStarted() Analogous to fe9479c (ros#1541).
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 3, 2020
dirk-thomas
pushed a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a combo bug report and resolution.
Currently calling
hasStarted()for a timer which hasn't been initialized properly just results innullptraccess. I added a short-circuit to prevent that from occurring.Scope
This change needs to be backported to Kinetic and Lunar (being maintained as of now). Doesn't affect Indigo
Details
The reported error post crash is: