Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rostopic pub from file and stdin. #1581

Open
wants to merge 2 commits into
base: noetic-devel
Choose a base branch
from

Conversation

LeroyR
Copy link

@LeroyR LeroyR commented Jan 18, 2019

publishing from file only send each message once and then stop.

This will change it to loop over the messages
and honor the --once option.

Please cherry pick into kinetic

@reinzor
Copy link

reinzor commented Aug 29, 2019

Pub from stdin indeed seems to be broken, so no enhancement. You can reproduce with:

roscore
echo "hi" | rostopic pub /chatter std_msgs/String
rostopic echo /chatter

@dirk-thomas
Copy link
Member

Closing due to long time of inactivity. Please consider opening a new PR targeting the current default branch if you are still interested in getting this patch merged.

@dirk-thomas dirk-thomas closed this Feb 4, 2020
@LeroyR
Copy link
Author

LeroyR commented Feb 5, 2020

????
I opened this one year ago, why didnt you merge then?

Should i get friends or pay someone to periodically upvote pull request?

@dirk-thomas
Copy link
Member

I opened this one year ago, why didnt you merge then?

Pub from stdin indeed seems to be broken, so no enhancement.

Because it was reported that the patch doesn't work. And no further comment happened after that.

Should i get friends or pay someone to periodically upvote pull request?

Simply replying to comments and if necessary addressing feedback is commonly enough to get PR reviewed and merged. Also #1496 describes why there is little activity on this repo.

Please feel free to continue commenting on the ticket and if applicable it can be reopened.

@LeroyR
Copy link
Author

LeroyR commented Feb 5, 2020

I dont see reports that this does not work.

From the comment i gather that this fixes a bug and thus is not an enhancement.

@dirk-thomas dirk-thomas reopened this Feb 5, 2020
@dirk-thomas
Copy link
Member

Ok, I misread the comment then. Reopened.

Please rebase the branch to resolve the conflicts.

publishing from file only send each message once and then stop.

This will change it to loop over the messages
and honor the --once option.
@LeroyR LeroyR force-pushed the fix/rostopic/stdin_and_file_loop_msgs branch from 60fc3e3 to abd248a Compare February 6, 2020 09:24
@dirk-thomas dirk-thomas changed the base branch from melodic-devel to noetic-devel October 5, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants