-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rostopic pub from file and stdin. #1581
base: noetic-devel
Are you sure you want to change the base?
Fix rostopic pub from file and stdin. #1581
Conversation
Pub from stdin indeed seems to be broken, so no enhancement. You can reproduce with:
|
Closing due to long time of inactivity. Please consider opening a new PR targeting the current default branch if you are still interested in getting this patch merged. |
???? Should i get friends or pay someone to periodically upvote pull request? |
Because it was reported that the patch doesn't work. And no further comment happened after that.
Simply replying to comments and if necessary addressing feedback is commonly enough to get PR reviewed and merged. Also #1496 describes why there is little activity on this repo. Please feel free to continue commenting on the ticket and if applicable it can be reopened. |
I dont see reports that this does not work. From the comment i gather that this fixes a bug and thus is not an enhancement. |
Ok, I misread the comment then. Reopened. Please rebase the branch to resolve the conflicts. |
publishing from file only send each message once and then stop. This will change it to loop over the messages and honor the --once option.
60fc3e3
to
abd248a
Compare
publishing from file only send each message once and then stop.
This will change it to loop over the messages
and honor the --once option.
Please cherry pick into kinetic