fix various test problems #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endency declared on it
dirk-thomas
force-pushed
the
fix_various_test_problems
branch
from
e7fe170 to
c786503
Compare
|
The CI failure is due to a test known to be flaky. |
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
* move test files to separate package * move publishtest into separate package since it requires rostopic which rostest can't depend on * [rosbag_storage] add missing dependency on std_msgs * duplicate talker.py test node since rospy doesn't install the file * modify test to pass when rospy.get_name isn't available without a dependency declared on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically all cases tried to use resources they don't depend on and there are not guaranteed to be accessible when building / testing only with the declared dependencies.
See #863 (comment) where one of the cases was introduced. In that case this patch only fixes the testing but the missing dependency at runtime is still a problem.