Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error handling for Topic constructor #1701

Merged
merged 1 commit into from
Apr 23, 2019
Merged

Fix error handling for Topic constructor #1701

merged 1 commit into from
Apr 23, 2019

Conversation

scooler
Copy link
Contributor

@scooler scooler commented Apr 23, 2019

There is no s variable in scope - and we clearly wanna display reg_type

To reproduce:

rospy.topics.Topic('/topic', rospy.AnyMsg, 'aa')

I get

raise TypeError("invalid reg_type: %s"%s)
NameError: global name 's' is not defined

@scooler
Fix error handling for Topic constructor
461d77d 
There is no s variable in scope - and we clearly wanna display
reg_type
@dirk-thomas
Copy link
Member

Thanks for the fix.

@dirk-thomas dirk-thomas merged commit 309753f into ros:melodic-devel Apr 23, 2019
@dirk-thomas dirk-thomas mentioned this pull request Aug 4, 2020
Merged
dirk-thomas pushed a commit that referenced this pull request Aug 4, 2020
@scooler @dirk-thomas
Fix error handling for Topic constructor (#1701)
eb4f6ba 
There is no s variable in scope - and we clearly wanna display
reg_type
dirk-thomas pushed a commit that referenced this pull request Aug 4, 2020
@scooler @dirk-thomas
Fix error handling for Topic constructor (#1701)
7385c90 
There is no s variable in scope - and we clearly wanna display
reg_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scooler @dirk-thomas