Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows][melodic-devel] Fixed test code when running Python scripts and rosrun. #1727

Merged
merged 1 commit into from
Oct 3, 2019
Merged

[Windows][melodic-devel] Fixed test code when running Python scripts and rosrun. #1727

merged 1 commit into from
Oct 3, 2019

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Jun 11, 2019

  • On platforms without shebang support, Python executable needs to be added explicitly to run scripts.
  • On Windows, rosrun.bat needs to be called explicitly from the test code.

@dirk-thomas
Copy link
Member

Please resolve conflicts.

@seanyen seanyen force-pushed the windows_port_test_windows branch from 335e7a3 to 5b52aee Compare August 12, 2019 22:17
@seanyen
Copy link
Contributor Author

seanyen commented Aug 13, 2019

@dirk-thomas I resolved the conflicts and rebased this pull request.

@seanyen
Copy link
Contributor Author

seanyen commented Aug 13, 2019

@ros-pull-request-builder retest this please

@dirk-thomas
Copy link
Member

@ros-pull-request-builder retest this please

@dirk-thomas
Copy link
Member

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 6b1ee1a into ros:melodic-devel Oct 3, 2019
@dirk-thomas dirk-thomas mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanyen @dirk-thomas