Wrap file names in quotes so they can be click selected in terminal #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasw
changed the title
|
The extra space before the period is pretty awkward / non-standard. How about wrapping the path in single quotes instead? |
It's convenient to click on the printed rosbag name to copy it and use as a parameter elsewhere, but the period will get included in the click without the quotes (at least in Ubuntu 18.04 + gnome terminal).
|
Changed to quotes. |
dirk-thomas
changed the title
|
Thanks for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's convenient to double click on the printed rosbag name to copy it and use as a parameter elsewhere, but the period will get included in the click (at least in Ubuntu 18.04 + gnome terminal).
Alternatively could eliminate the periods in all but one of the cases above.