[windows][melodic] use c++11 std::snprintf #1820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is in favor of
C++11
std::snprintf
usage and to remove MSVC specific CRT functions_snprintf_s
.This change is motivated by a name conflicts against
Boost
. Beginning fromBoost v1.69
, a new additionsystem_category_win32.hpp
is added toBoost.System
, and in this header, it refers tostd::snprintf
in a code path. And becausesnprintf
has been redefined as_snprintf_s
in many places inros_comm
, it subsequently replacesstd::snprintf
withstd::_snprintf_s
and results in compiler errors.