Remove (potentially) recursive DEBUG statements #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alternatively: this is the offending log statement: ros_comm/clients/roscpp/src/libros/param.cpp Line 299 in d487d58 Is it likely that people are debugging the cache in normal operation? Is this something that could be removed? |
mjcarroll
force-pushed
the
fix_recursive_print
branch
from
f0c135e to
c6a6c07
Compare
mjcarroll
changed the title
dirk-thomas
reviewed
Oct 11, 2019
mjcarroll
force-pushed
the
fix_recursive_print
branch
from
c6a6c07 to
051cec9
Compare
These statements can potentially be called from within a logging function, which causes a "recursive print" warning. Signed-off-by: Michael Carroll <michael@openrobotics.org>
mjcarroll
force-pushed
the
fix_recursive_print
branch
from
051cec9 to
ae35b6c
Compare
|
These debug messages can be useful sometimes, but while I personally prefer #1597 this is also acceptable to me. |
|
@ros-pull-request-builder retest this please |
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative fix to #1241. This also addresses ros/rosconsole#30
When using a log level of
debug, every logging statement will have console output:Warning: recursive print statement has occurred. Throwing out recursive print.The logic introduced in #1241 uses
getCachedwhich will cause a second logging statement to occur recursively when log level is set to debug.Edit: This has been updated to remove the offending DEBUG statements so that it will work in all cases.