Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] use double quotes for portable roslaunch-check command. #1883

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

seanyen
Copy link
Contributor

@seanyen seanyen commented Feb 15, 2020

On Windows, the single quotes will be passed the executable and won't be escaped. In this case, it causes that this line always returns None and throws exceptions like below.

pkg = rospkg.get_package_name(roslaunch_path)

Traceback (most recent call last):
  File "C:\opt\ros\melodic\x64\share\roslaunch\scripts\roslaunch-check", line 90, in <module>
    pkg_dir = r.get_path(pkg)
  File "C:\opt\python27amd64\lib\site-packages\rospkg\rospack.py", line 203, in get_path
    raise ResourceNotFound(name, ros_paths=self._ros_paths)
rospkg.common.ResourceNotFound: <exception str() failed>

@seanyen
Copy link
Contributor Author

seanyen commented Feb 18, 2020

@dirk-thomas This is ready for review and merge. Thanks!

@dirk-thomas
Copy link
Member

@ros-pull-request-builder retest this please

@dirk-thomas
Copy link
Member

Thanks for the patch.

@dirk-thomas dirk-thomas merged commit 7ad4625 into ros:melodic-devel Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants