fixed minor overflow bugs in Time and Duration #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@subject-name-here Thank you for pointing out these issue and proposing a fix. The new tests have been very helpful. The actual code changes to make the tests pass seem a bit "too complicated" to me. Since I couldn't describe why and how it should look like instead I tried to come up with a simpler patch which passes your tests. Please see the proposed changes in #61. Do you agree that #61 also addresses the issue sufficiently and is slightly easier to read / understand? |
|
@dirk-thomas Yes, I agree. Your patch is much easier to read and it covers the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.