Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix formatting of XacroException #172

Merged
merged 1 commit into from
Nov 16, 2017
Merged

fix formatting of XacroException #172

merged 1 commit into from
Nov 16, 2017
+2 −2

Conversation

rhaschke
Copy link
Contributor

This PR improves formatting of xacro exceptions. Instead of

None name 'prop1' is not defined 
when evaluating expression 'prop1'
XacroException(None,)
when processing file: ifdef.xml

the message now becomes:

name 'prop1' is not defined 
when evaluating expression 'prop1'
when processing file: ifdef.xml

@codebot codebot merged commit 7000399 into ros:lunar-devel Nov 16, 2017
@rhaschke rhaschke deleted the fix-error-formatting branch November 24, 2017 09:50
rhaschke added a commit to ubi-agni/xacro that referenced this pull request Mar 27, 2018
@rhaschke
cherry-pick ros#172: fix formatting of XacroException
2c47674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhaschke @codebot