Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-Vendor communication is not guaranteed by design. #4736

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

fujitatomoya
Copy link
Collaborator

closes ros2/ros2cli#586 and #3288

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Collaborator Author

@clalancette @wjwwood @mjcarroll @alsora @ahcorde what do you think? I think at lease we can provide the information like this for now.

Copy link

github-actions bot commented Sep 12, 2024

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/10985434098/artifacts/1963988524.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4736/index.html in your favorite browser

Copy link
Contributor

@alsora alsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with adding this.

@fujitatomoya
Copy link
Collaborator Author

@alsora @ahcorde thanks for the approval.

@clalancette what do you think? if i remember correctly, we have talked about this long time before, and there was no clear decision. we knew that this is frowned upon, but did not want to explicitly note this? just checking, please let me know your thoughts.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of adding in a note. I've rewritten it in my suggestion; what do you think?

@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Sep 21, 2024
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@clalancette clalancette merged commit 355ed2c into rolling Sep 23, 2024
4 checks passed
@clalancette clalancette deleted the fujitatomoya/cross-vendor-communication-note branch September 23, 2024 00:52
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)
mergify bot pushed a commit that referenced this pull request Sep 23, 2024
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)
clalancette pushed a commit that referenced this pull request Sep 23, 2024
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette pushed a commit that referenced this pull request Sep 23, 2024
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
clalancette pushed a commit that referenced this pull request Sep 23, 2024
* Cross-Vendor communication is not guaranteed by design.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
(cherry picked from commit 355ed2c)

Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ros2 param list does not work with multiple rmw implementaion
4 participants