Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish the ROS 1 -> 2 CMake instructions (backport #4767) #4776

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 30, 2024

This updates the CMake portion of the ROS 1 to ROS 2 guide, and fixes one bug in the C++ code

  • Included links to real examples in the core (Mostly tf2)
  • Updated section headings to CMakeLists.txt steps appear in the ToC
  • Used modern CMake targets instead of standard CMake variables
  • Used Active voice and second person perspective
  • Removed unnecessary code from example code in Unit tests section
  • Make the example package.xml start with format 2 since that's different from migrating from ROS 1 to ROS 2.

C++ bug fix: use ->publish( instead of .publish(

I have tried out all steps of the example part of the guide to make sure they work.


This is an automatic backport of pull request #4767 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from clalancette as a code owner September 30, 2024 17:51
@mergify mergify bot added the conflicts label Sep 30, 2024
@mergify mergify bot requested a review from audrow as a code owner September 30, 2024 17:51
Copy link
Contributor Author

mergify bot commented Sep 30, 2024

Cherry-pick of 9d6552c has failed:

On branch mergify/bp/iron/pr-4767
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 9d6552c0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   source/How-To-Guides/Migrating-from-ROS1/Migrating-CPP-Packages.rst

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

* Polish the ROS 1 -> 2 CMake instructions

* Use section headings to CMakeLists.txt steps appear in the TOC
* Use modern CMake targets instead of standard CMake variables
* Use Active voice and second person perspective
* Include links to real examples

Signed-off-by: Shane Loretz <shane.loretz@gmail.com>
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
(cherry picked from commit 9d6552c)
Copy link

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/11111498343/artifacts/1996947739.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-4776/index.html in your favorite browser

@clalancette clalancette merged commit d5641e2 into iron Sep 30, 2024
4 checks passed
@clalancette clalancette deleted the mergify/bp/iron/pr-4767 branch September 30, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants