-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feedbacks #8
Comments
Wow, first thank you for this much appreciated feedback ! Yes I read the recent article in the remix blog and it's a good summary of how to do i18n with remix. lang in urlFor the lang in the url, the main reason why I didn't do it is that I don't like to have everything prefixed by an optional segment. That being said, what you suggest can be done but it might be interesting to see if we can do something similar to what NextJS do with i18n routing : https://nextjs.org/docs/app/building-your-application/routing/internationalization#routing-overview Maybe with vite, we can figure out something so that we don't have to prefix everything even if remix-flat-routes is a big help. 18next-parser configurationI think it got deleted when I move the example to epic-stack with remix-v2. Here is the PR #10 where It's back. github actionVery good idea, I created a separate issue to track a solution #11 unwanted redirectThis is a bug, it should not behave that way. Here is the PR #12 with the fix. missing examples of translationYou are right, meta translation should be easy. Very nice solution for playwright I will give it a try. |
thank you for the PRs and for the creation of the issues. I added a review on #10 I have some refacto to do on my code now hahaha Also 18next-parser does not work with dynamic keys |
Your welcome 👍 Yes for dynamic key, the recommended way to do that is with comments: https://github.com/i18next/i18next-parser?tab=readme-ov-file#caveats . I need to look for a dynamic key inside the stack so it can be a good example, will add to the readme. update: it's already on the readme inside the 22/09/2023 update |
I added an example on how to setup i18next with testing-library ☝️ |
I've created a first PR for a playwright implementation #13 . |
hey! thank you for the template. Here are some feedbacks and config suggestions
lang in url
I would love to see the lang in the url for:
There's a very recent article on that on the remix blog. Have you seen it? https://remix.run/blog/remix-i18n
I'm thinking maybe to not have to prefix everything with ($lang) as it's suggested in part3 of the article, we could have a routes folder structure like
of course a search param like
?lang=
is not an option for SEO18next-parser configuration
I saw a reference in the readme to i18next-parser but no reference in the code to it. I added it to the dev dependencies and then added a script to package.json
also we could specify in readme that i18next-parser does not support react specific
<Trans />
componentgithub action
nice to have final feature: a github action that checks there are no missing translation (some in the code but not in the translation json file)
unwanted redirect
Also maybe I missed something when I implemented epic-stack-with-i18n in my project but I get redirected to root when I switch lang
missing examples of translation
export const meta: MetaFunction
example to setup e2e tests with translations
example to setup testing-library tests with translations
when I run the tests, they pass as is, I18nextProvider doesn't seem needed
Final word
thank you for the template. Keep up the good work.
You can close the issue when you read, or let it open for others to give feedback
The text was updated successfully, but these errors were encountered: