Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back i18next-parser-config #10

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Add back i18next-parser-config #10

merged 3 commits into from
Mar 8, 2024

Conversation

rperon
Copy link
Owner

@rperon rperon commented Mar 8, 2024

i18next parser config got deleted when upgrading. It is now back and can be used with the command:
> npx i18next

Test Plan

Checklist

  • Tests updated
  • Docs updated

Screenshots

@rperon rperon mentioned this pull request Mar 8, 2024
@rperon rperon merged commit ac1c01d into main Mar 8, 2024
4 checks passed
@rperon rperon deleted the add-i18next-parser branch March 8, 2024 15:41
@@ -0,0 +1,112 @@
// i18next-parser.config.js

export default {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be simpler to replace this file by just what we are using and let the defaults not mentioned. It is also safer to do so because you get less breaking changes over time if the package maintainers introduce breaking changes on config properties @rperon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants