Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor i18n configuration following remix-i18next update #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rperon
Copy link
Owner

@rperon rperon commented Mar 8, 2024

Update based on Sergio Xalambri example.

Test Plan

Checklist

  • Tests updated
  • Docs updated

Screenshots

@rperon rperon changed the title Refactor i18n configuration and update dependencies Refactor i18n configuration following remix-i18next update Mar 8, 2024
@rperon rperon mentioned this pull request Mar 8, 2024
@fredericrous
Copy link

fredericrous commented Mar 8, 2024

looks great. I like the fact you moved the files from locales/en/common.json to a simpler and more friendly locales/en.json. As I was saying in a deleted comment, I worked for all size of companies and products, having one file per locale per product is the easiest and most common way I've seen

--

update: I implemented this PR on my project, everything works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants