Two quick fixes for sidebar mobile/desktop options (#950)

* fix(sidebar): open="desktop" resolves to `"closed"` on mobile * fix(toggle_sidebar): `"toggle"` is a valid `open` value
rstudio · Dec 20, 2023 · c1979d0 · c1979d0
1 parent 3140888
commit c1979d0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/R/sidebar.R b/R/sidebar.R
@@ -238,7 +238,7 @@ as_sidebar_open_on <- function(open) {
   if (length(open) == 1) {
     open <- sidebar_open_as_string(open, extra = "desktop", rlang::caller_env())
     if (identical(open, "desktop")) {
-      return(sidebar_open_on("open", "always"))
+      return(sidebar_open_on("open", "closed"))
     }
     return(sidebar_open_on(open, open))
   }
@@ -396,7 +396,7 @@ layout_sidebar <- function(
 #'   used).
 #' @export
 toggle_sidebar <- function(id, open = NULL, session = get_current_session()) {
-  method <- sidebar_open_as_string(open %||% "toggle")
+  method <- sidebar_open_as_string(open %||% "toggle", "toggle")
 
   if (identical(method, "always")) {
     abort('`open = "always"` is not supported by `sidebar_toggle()`.')