Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two quick fixes for sidebar mobile/desktop options #950

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Two quick fixes for sidebar mobile/desktop options #950

merged 2 commits into from
Dec 20, 2023

Conversation

gadenbuie
Copy link
Member

Two quick follow-ups for #943

  • Fixes a typo that set open = "desktop" equal to list(desktop = "open", mobile = "always") instead of mobile = "closed".
  • Adds "toggle" to the valid choices for open in toggle_sidebar()

@gadenbuie gadenbuie requested a review from cpsievert December 20, 2023 15:29
@gadenbuie gadenbuie merged commit c1979d0 into main Dec 20, 2023
12 checks passed
@gadenbuie gadenbuie deleted the fix/sidebar-open-on-follow-up branch December 20, 2023 15:43
@gadenbuie gadenbuie mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gadenbuie @cpsievert