Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HEAD placeholder in html template for shiny_prerendered #344

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Jun 22, 2021

It should fix #343

This follows changes in

I should have thought to update the template in flexdashboard following this change.

It could be a good idea to update the rmarkdown requirement to >= 2.8 but it may not be necessary for this to work. It is the other way around: if you have rmarkdown 2.8 or above you need this version of flexdashboard. Not sure we can do it in this way. If you don't see an issue, I would bump the requirement. (which you may need to do already for bslib support)

@cderv
Copy link
Collaborator Author

cderv commented Jun 22, 2021

About CI, seems there is an issue with htmltools installation. Which also happens in your main CI.
You may already know that.

@cderv cderv requested a review from cpsievert June 23, 2021 14:53
@cpsievert
Copy link
Collaborator

cpsievert commented Jun 23, 2021

Thanks for the fix and the context! I like the idea of requiring >= 2.8.

@cpsievert cpsievert merged commit 42d7329 into master Jun 23, 2021
@cpsievert cpsievert deleted the fix/343-shiny-prerendered branch June 23, 2021 15:48
@cderv
Copy link
Collaborator Author

cderv commented Jun 23, 2021

Great !

On second thought, you could prefer last rmarkdown 2.9 as minimal version because we fixed a regression in 2.8 and there are some improvement with rmarkdown::run for shiny runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bslib stylesheet overrides do not work with shiny_prerendered and rmarkdown 2.8
2 participants