fix invalid HTML code in shiny_prerendered documents #1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks a ton. By when this will be merged with rstudio:master? |
3 tasks
schloerke
approved these changes
Feb 25, 2021
jcheng5
reviewed
Feb 25, 2021
jcheng5
reviewed
Feb 25, 2021
R/shiny_prerendered.R
Outdated
|
|
||
| # create shiny app | ||
| shiny::shinyApp( | ||
| ui = function(req) html, | ||
| ui = function(req) html_doc, |
There was a problem hiding this comment.
Unrelated to this change, but this can just be ui = html_doc, since the value is static
cderv
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Thanks @jcheng5 and @schloerke for the review.
@dakep I'll do the change and merge. Thanks a lot for this PR !
|
Thanks @dakep ! |
gadenbuie
reviewed
Feb 26, 2021
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Mar 3, 2021
Merge remote-tracking branch 'rstudio_origin/master' into jg-devel * rstudio_origin/master: (26 commits) Use data-external=1 to prevent encoding by Pandoc of img src add `subdirs` documentation for site generator (rstudio#2058) fix: corrected typo in `ghostscript` (rstudio#2059) Add CoC contact email quillt has moved to rstudio/quillt fix invalid HTML code in shiny_prerendered documents (rstudio#1942) Allow pkgdown PR preview (rstudio#2055) Adding pkgdown site built by GHA (rstudio#1955) Add shiny bslib dependency inside html_document_base pre-process (rstudio#2049) start the next version CRAN release v2.7 place <div> in \code{} amend 62ae2ed and rstudio#1989: make sure output_format_filter is a function; testing NULL is not enough, e.g., the radix package still calls use CRAN releases of shiny and bslib tweak news Only keep the first url in citation (rstudio#2041) Fix for knit_print.data.frame (rstudio#2050) set gfm_auto_identifiers to input format if toc is TRUE (rstudio#2040) Enable pkgdown/downlit cross-package links to rmarkdown (rstudio#1843) update CONTRIBUTING.md ... # Conflicts: # DESCRIPTION
cderv
added a commit
that referenced
this pull request
Mar 4, 2021
A new pandoc variable `shiny-prerendered` is set when rendering a shiny prerendered document. This allow to add specific content for this type of rendered document in an HTML template. It is used in all HTML templates to add a special comment `<!-- HEAD_CONTENT -->` required by htmltools / shiny to reinsert the HTML dependencies. Following #1942, it was put by default at the end of the error which caused issue in leanr, e.g rstudio/learnr#499 This will fix #2060 following change in 49c0c2b.
cderv
added a commit
to rstudio/flexdashboard
that referenced
this pull request
Jun 22, 2021
This follows change in rstudio/rmarkdown#1942 and rstudio/rmarkdown#2064
cpsievert
pushed a commit
to rstudio/flexdashboard
that referenced
this pull request
Jun 23, 2021
* Add HEAD placeholder in html template for shiny_prerendered This follows change in rstudio/rmarkdown#1942 and rstudio/rmarkdown#2064 * update NEWS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1912. Instead of an HTML string containing the entire document (which is not recognized as stand-alone html document by shiny), return an html_document object with the dependencies already injected.