Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Avoid throwing errors for shared input/output IDs (#4101)
* refactor: Factor out message display from error handler * feat: Add custom event for sending a client message * feat: Report binding validity problem via event instead of throwing error * feat: Don't need to hide shared input/output message Now that it's not an error, it's safe to report * refactor: Move `inDevMode()` logic into error console * refactor: Rename `.error` --> `.event` * feat: wrap client error message It's otherwise hard to tell that the error is scrollable Plus the scrolling is over the whole message rather than the part that overflows * feat: always send client console messages to browser console as well * chore: throw if `shiny:client-message` receives an event that isn't CustomEvent * feat: Handle status in `showShinyClientMessage()` * Renamed `showMessageInClientConsole()` to `showShinyClientMessage()` to improve clarity * Added `status` argument to `showShinyClientMessage()` to allow for different message types * refactor: Don't throw errors for duplicate IDs Brings dev mode in line with current "prod" behavior, where errors aren't thrown for duplciates. In both cases we still get console or client messages. * refactor: Clean up `status` inside `checkValidity()` * refactor: Have `checkValidity()` handle emitting the client console event
- Loading branch information