Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Avoid throwing errors for shared input/output IDs #4101

Merged
merged 29 commits into from
Dec 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
ad4a482
refactor: Factor out message display from error handler
gadenbuie Jul 15, 2024
4cd7e72
feat: Add custom event for sending a client message
gadenbuie Jul 15, 2024
04a6d9d
feat: Report binding validity problem via event instead of throwing e…
gadenbuie Jul 15, 2024
2c028df
feat: Don't need to hide shared input/output message
gadenbuie Jul 15, 2024
006df8b
refactor: Move `inDevMode()` logic into error console
gadenbuie Jul 15, 2024
b7f26ac
refactor: Rename `.error` --> `.event`
gadenbuie Jul 15, 2024
bd62b28
`devtools::document()` (GitHub Actions)
gadenbuie Jul 15, 2024
9cfc437
`yarn build` (GitHub Actions)
gadenbuie Jul 15, 2024
651d9a1
feat: Do throw error for duplicated input or output IDs
gadenbuie Jul 15, 2024
77d1153
feat: wrap client error message
gadenbuie Jul 15, 2024
2db9ce8
`yarn build` (GitHub Actions)
gadenbuie Jul 15, 2024
236a9e2
Merge branch 'main' into feat/client-message-event
gadenbuie Sep 27, 2024
eb513a7
feat: always send client console messages to browser console as well
gadenbuie Sep 30, 2024
c8bc385
chore: throw if `shiny:client-message` receives an event that isn't C…
gadenbuie Sep 30, 2024
2d47c2f
chore: apply suggestions from code review
gadenbuie Sep 30, 2024
d57045c
Merge 'origin/main' into branch feat/client-message-event
gadenbuie Sep 30, 2024
a6b4452
`yarn build` (GitHub Actions)
gadenbuie Sep 30, 2024
7963436
feat: Handle status in `showShinyClientMessage()`
gadenbuie Oct 1, 2024
820a8a9
docs: Add NEWS items
gadenbuie Oct 1, 2024
a6fd6c9
refactor: Don't throw errors for duplicate IDs
gadenbuie Dec 5, 2024
13b1b2e
Merge 'origin/main' into branch feat/client-message-event
gadenbuie Dec 5, 2024
cac8491
docs: Update NEWS item
gadenbuie Dec 5, 2024
357b126
`yarn build` (GitHub Actions)
gadenbuie Dec 5, 2024
f5fa38b
refactor: Clean up `status` inside `checkValidity()`
gadenbuie Dec 6, 2024
1aa2c10
`yarn build` (GitHub Actions)
gadenbuie Dec 6, 2024
e4e2ea2
refactor: Have `checkValidity()` handle emitting the client console e…
gadenbuie Dec 6, 2024
f82331a
`yarn build` (GitHub Actions)
gadenbuie Dec 6, 2024
835b703
Merge 'origin/main' into branch feat/client-message-event
gadenbuie Dec 6, 2024
84e3321
`yarn build` (GitHub Actions)
gadenbuie Dec 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: apply suggestions from code review
  • Loading branch information
gadenbuie committed Sep 30, 2024
commit 2d47c2f6d17fd4c685effed7a78bb01dc28db6e3
4 changes: 2 additions & 2 deletions srcts/src/shiny/bind.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const bindingsRegistry = (() => {
// Duplicates within a single binding type are an error.
status = "error";
} else {
// Duplicates across binding types are a warning.
// Same ID used for 1 input and 1 output results in a warning not error.
status = "warning";
}
});
Expand Down Expand Up @@ -140,7 +140,7 @@ const bindingsRegistry = (() => {
status: "warning",
event: new ShinyClientMessageEvent({
headline: "Shared input/output IDs found",
message: message,
message,
}),
};
}
Expand Down