Drop support for Rails 4.1 or lower

Follow up to #222. This PR drops support for Rails 4.1 or lower. RuboCop Rails 2.6 will drop support for Rails 4.1 or lower. Maybe RuboCop Rails 3.0 will drop Rails 4 series support in future. RuboCop Rails is currently negative support for Rails 4 series, and new features for Rails 4 will basically not be accepted.
rubocop · Apr 21, 2020 · 98dec2b · 98dec2b
1 parent 2c860fc
commit 98dec2b
Show file tree

Hide file tree

Showing 10 changed files with 80 additions and 112 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@
 ### Changes
 
 * [#233](https://github.com/rubocop-hq/rubocop-rails/pull/233): **(BREAKING)** Drop support for Ruby 2.3. ([@koic][])
+* [#236](https://github.com/rubocop-hq/rubocop-rails/pull/236): **(BREAKING)** Drop support for Rails 4.1 or lower. ([@koic][])
 
 ## 2.5.2 (2020-04-09)
 

diff --git a/README.md b/README.md
@@ -84,7 +84,7 @@ You can read a lot more about RuboCop Rails in its [official docs](https://docs.
 
 Rails cops support the following versions:
 
-- Rails 4.0+
+- Rails 4.2+
 
 ## Contributing
 

diff --git a/lib/rubocop/cop/rails/http_positional_arguments.rb b/lib/rubocop/cop/rails/http_positional_arguments.rb
@@ -8,7 +8,7 @@ module Rails
       # change them to use keyword args. This cop only applies to Rails >= 5.
       # If you are running Rails < 5 you should disable the
       # Rails/HttpPositionalArguments cop or set your TargetRailsVersion in your
-      # .rubocop.yml file to 4.0, etc.
+      # .rubocop.yml file to 4.2.
       #
       # @example
       #   # bad

diff --git a/lib/rubocop/cop/rails/inverse_of.rb b/lib/rubocop/cop/rails/inverse_of.rb
@@ -129,10 +129,6 @@ module Rails
       # @see https://guides.rubyonrails.org/association_basics.html#bi-directional-associations
       # @see https://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#module-ActiveRecord::Associations::ClassMethods-label-Setting+Inverses
       class InverseOf < Cop
-        extend TargetRailsVersion
-
-        minimum_target_rails_version 4.1
-
         SPECIFY_MSG = 'Specify an `:inverse_of` option.'
         NIL_MSG = 'You specified `inverse_of: nil`, you probably meant to ' \
           'use `inverse_of: false`.'

diff --git a/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb b/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb
@@ -55,11 +55,8 @@ module Rails
       #     end
       #   end
       class RedundantReceiverInWithOptions < Cop
-        extend TargetRailsVersion
         include RangeHelp
 
-        minimum_target_rails_version 4.2
-
         MSG = 'Redundant receiver in `with_options`.'
 
         def_node_matcher :with_options?, <<~PATTERN

diff --git a/manual/cops_rails.md b/manual/cops_rails.md
@@ -1020,7 +1020,7 @@ This cop is used to identify usages of http methods like `get`, `post`,
 change them to use keyword args. This cop only applies to Rails >= 5.
 If you are running Rails < 5 you should disable the
 Rails/HttpPositionalArguments cop or set your TargetRailsVersion in your
-.rubocop.yml file to 4.0, etc.
+.rubocop.yml file to 4.2.
 
 ### Examples
 

diff --git a/rubocop-rails.gemspec b/rubocop-rails.gemspec
@@ -31,7 +31,7 @@ Gem::Specification.new do |s|
     'bug_tracker_uri' => 'https://github.com/rubocop-hq/rubocop-rails/issues'
   }
 
-  s.add_runtime_dependency 'activesupport'
+  s.add_runtime_dependency 'activesupport', '>= 4.2.0'
   # Rack::Utils::SYMBOL_TO_STATUS_CODE, which is used by HttpStatus cop, was
   # introduced in rack 1.1
   s.add_runtime_dependency 'rack', '>= 1.1'

diff --git a/spec/rubocop/config_spec.rb b/spec/rubocop/config_spec.rb
@@ -27,7 +27,7 @@
       end
 
       context 'correctly' do
-        let(:rails_version) { 4.0 }
+        let(:rails_version) { 6.0 }
 
         it 'uses TargetRailsVersion' do
           expect(configuration.target_rails_version).to eq rails_version

diff --git a/spec/rubocop/cop/rails/redundant_receiver_in_with_options_spec.rb b/spec/rubocop/cop/rails/redundant_receiver_in_with_options_spec.rb
@@ -3,110 +3,92 @@
 RSpec.describe RuboCop::Cop::Rails::RedundantReceiverInWithOptions, :config do
   subject(:cop) { described_class.new(config) }
 
-  context 'Rails >= 4.2', :rails42 do
-    it 'registers an offense and corrects using explicit receiver ' \
+  it 'registers an offense and corrects using explicit receiver ' \
       'in `with_options`' do
-      expect_offense(<<~RUBY)
-        class Account < ApplicationRecord
-          with_options dependent: :destroy do |assoc|
-            assoc.has_many :customers
-            ^^^^^ Redundant receiver in `with_options`.
-            assoc.has_many :products
-            ^^^^^ Redundant receiver in `with_options`.
-            assoc.has_many :invoices
-            ^^^^^ Redundant receiver in `with_options`.
-            assoc.has_many :expenses
-            ^^^^^ Redundant receiver in `with_options`.
-          end
+    expect_offense(<<~RUBY)
+      class Account < ApplicationRecord
+        with_options dependent: :destroy do |assoc|
+          assoc.has_many :customers
+          ^^^^^ Redundant receiver in `with_options`.
+          assoc.has_many :products
+          ^^^^^ Redundant receiver in `with_options`.
+          assoc.has_many :invoices
+          ^^^^^ Redundant receiver in `with_options`.
+          assoc.has_many :expenses
+          ^^^^^ Redundant receiver in `with_options`.
         end
-      RUBY
+      end
+    RUBY
 
-      expect_correction(<<~RUBY)
-        class Account < ApplicationRecord
-          with_options dependent: :destroy do
-            has_many :customers
-            has_many :products
-            has_many :invoices
-            has_many :expenses
-          end
+    expect_correction(<<~RUBY)
+      class Account < ApplicationRecord
+        with_options dependent: :destroy do
+          has_many :customers
+          has_many :products
+          has_many :invoices
+          has_many :expenses
         end
-      RUBY
-    end
-
-    it 'does not register an offense when using inplicit receiver ' \
-       'in `with_options`' do
-      expect_no_offenses(<<~RUBY)
-        class Account < ApplicationRecord
-          with_options dependent: :destroy do
-            has_many :customers
-            has_many :products
-            has_many :invoices
-            has_many :expenses
-          end
-        end
-      RUBY
-    end
+      end
+    RUBY
+  end
 
-    it 'registers an offense and corrects when including multiple ' \
-      'redendant receivers in single line' do
-      expect_offense(<<~RUBY)
-        with_options options: false do |merger|
-          merger.invoke(merger.something)
-          ^^^^^^ Redundant receiver in `with_options`.
-                        ^^^^^^ Redundant receiver in `with_options`.
+  it 'does not register an offense when using inplicit receiver ' \
+     'in `with_options`' do
+    expect_no_offenses(<<~RUBY)
+      class Account < ApplicationRecord
+        with_options dependent: :destroy do
+          has_many :customers
+          has_many :products
+          has_many :invoices
+          has_many :expenses
         end
-      RUBY
+      end
+    RUBY
+  end
 
-      expect_correction(<<~RUBY)
-        with_options options: false do
-          invoke(something)
-        end
-      RUBY
-    end
+  it 'registers an offense and corrects when including multiple ' \
+     'redendant receivers in single line' do
+    expect_offense(<<~RUBY)
+      with_options options: false do |merger|
+        merger.invoke(merger.something)
+        ^^^^^^ Redundant receiver in `with_options`.
+                      ^^^^^^ Redundant receiver in `with_options`.
+      end
+    RUBY
 
-    it 'does not register an offense when including method invocations ' \
-       'to different receivers' do
-      expect_no_offenses(<<~RUBY)
-        client = ApplicationClient.new
-        with_options options: false do |merger|
-          client.invoke(merger.something, something)
-        end
-      RUBY
-    end
+    expect_correction(<<~RUBY)
+      with_options options: false do
+        invoke(something)
+      end
+    RUBY
+  end
 
-    it 'does not register an offense when including block node' \
-       'in `with_options`' do
-      expect_no_offenses(<<~RUBY)
-        with_options options: false do |merger|
-          merger.invoke
-          with_another_method do |another_receiver|
-            merger.invoke(another_receiver)
-          end
-        end
-      RUBY
-    end
+  it 'does not register an offense when including method invocations ' \
+     'to different receivers' do
+    expect_no_offenses(<<~RUBY)
+      client = ApplicationClient.new
+      with_options options: false do |merger|
+        client.invoke(merger.something, something)
+      end
+    RUBY
+  end
 
-    it 'does not register an offense when empty' do
-      expect_no_offenses(<<~RUBY)
-        with_options options: false do |merger|
+  it 'does not register an offense when including block node' \
+     'in `with_options`' do
+    expect_no_offenses(<<~RUBY)
+      with_options options: false do |merger|
+        merger.invoke
+        with_another_method do |another_receiver|
+          merger.invoke(another_receiver)
         end
-      RUBY
-    end
+      end
+    RUBY
   end
 
-  context 'Rails <= 4.1', :rails41 do
-    it 'does not register an offense when using explicit receiver in ' \
-       '`with_options`' do
-      expect_no_offenses(<<~RUBY)
-        class Account < ApplicationRecord
-          with_options dependent: :destroy do |assoc|
-            assoc.has_many :customers
-            assoc.has_many :products
-            assoc.has_many :invoices
-            assoc.has_many :expenses
-          end
-        end
-      RUBY
-    end
+  it 'does not register an offense when empty' do
+    expect_no_offenses(<<~RUBY)
+      with_options options: false do |merger|
+      end
+    RUBY
   end
 end
diff --git a/spec/support/shared_contexts.rb b/spec/support/shared_contexts.rb
@@ -1,13 +1,5 @@
 # frozen_string_literal: true
 
-RSpec.shared_context 'with Rails 4.0', :rails40 do
-  let(:rails_version) { 4.0 }
-end
-
-RSpec.shared_context 'with Rails 4.1', :rails41 do
-  let(:rails_version) { 4.1 }
-end
-
 RSpec.shared_context 'with Rails 4.2', :rails42 do
   let(:rails_version) { 4.2 }
 end