Install dependencies into the same root as debugger itself #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps with --user-install on system ruby
valich
reviewed
Jun 4, 2019
| @@ -1,3 +1,4 @@ | |||
| install_dir = File.expand_path("../../../..", __FILE__) | |||
There was a problem hiding this comment.
What should ../../../.. denote?
There was a problem hiding this comment.
It would be great to add this as a comment for the further maintainers :)
valich
reviewed
Jun 4, 2019
ext/mkrf_conf.rb
Outdated
| @@ -27,11 +28,11 @@ def already_installed(dep) | |||
|
|
|||
| begin | |||
| puts "Installing base gem" | |||
| inst = Gem::DependencyInstaller.new :prerelease => dep.prerelease? | |||
| inst = Gem::DependencyInstaller.new :prerelease => dep.prerelease?, :install_dir => install_dir | |||
There was a problem hiding this comment.
Since we're here, could you please align code style in lines you've changed? One uses parentheses, while the other does not
There was a problem hiding this comment.
Sure, just it looks weird so I think it's better to fix such inconsistencies
|
Thank you! Merged. |
ViugiNick
pushed a commit
to ViugiNick/ruby-debug-ide
that referenced
this pull request
Nov 1, 2019
…g#172) * Install dependencies into the same root as debugger itself Helps with --user-install on system ruby
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with
--user-installon system rubyhttps://youtrack.jetbrains.com/issue/RUBY-20930