Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependencies into the same root as debugger itself #172

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Install dependencies into the same root as debugger itself #172

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b77241
Install dependencies into the same root as debugger itself
hurricup May 24, 2019
172c057
Added parens
hurricup Jun 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ext/mkrf_conf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
install_dir = File.expand_path("../../../..", __FILE__)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should ../../../.. denote?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add this as a comment for the further maintainers :)

jruby = defined?(JRUBY_VERSION) || (defined?(RUBY_ENGINE) && 'jruby' == RUBY_ENGINE)
rbx = defined?(RUBY_ENGINE) && 'rbx' == RUBY_ENGINE

Expand Down Expand Up @@ -27,11 +28,11 @@ def already_installed(dep)

begin
puts "Installing base gem"
inst = Gem::DependencyInstaller.new :prerelease => dep.prerelease?
inst = Gem::DependencyInstaller.new(:prerelease => dep.prerelease?, :install_dir => install_dir)
inst.install dep
rescue
begin
inst = Gem::DependencyInstaller.new(:prerelease => true)
inst = Gem::DependencyInstaller.new(:prerelease => true, :install_dir => install_dir)
inst.install dep
rescue Exception => e
puts e
Expand Down