Fix darkfish responsiveness issue on screens between 1024px and ~1650px #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In that range, the sidebar would be displayed and cover part of the content. This commit fixes that by adding a left margin to the content when the screen size is greater than 1024px.
Currently, sidebar's height is reduced to avoid covering up the footer. But this cuts the sidebar short even before the footer is reached. Alternatively, we can achieve the same effect by increasing the footer's z-index to make it appear on top of the sidebar.
MatheusRich
reviewed
Aug 5, 2024
colby-swandale
approved these changes
Aug 8, 2024
st0012
added a commit
to Shopify/ruby
that referenced
this pull request
Aug 8, 2024
This syncs changes made in ruby/rdoc#1148, which will fix https://docs.ruby-lang.org/en/master/'s display on certain screens.
k0kubun
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 8, 2024
Sync rdoc This syncs changes made in ruby/rdoc#1148, which will fix https://docs.ruby-lang.org/en/master/'s display on certain screens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In that range, the sidebar would be displayed and cover part of the content. This PR fixes that by adding a left margin to the content when the screen size is greater than 1024px.
I also improved how the footer is displayed: instead of cutting the sidebar short to avoid covering it, we can increase the footer's z-index instead.
Before
After