Fix sidebar scroll and footer display #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensured the footer is part of the `nav` and sticks to the bottom by default, appearing at the bottom of the scroll when content overflows. - Applied flexbox layout to `nav` and `main` to manage space distribution.
colby-swandale
approved these changes
Aug 12, 2024
Merged
st0012
added a commit
that referenced
this pull request
Aug 15, 2024
In #1152 the footer partial was only added to the index.rhtml file. This commit adds the footer partial to the other template files.
st0012
added a commit
that referenced
this pull request
Aug 15, 2024
* Add missing footers In #1152 the footer partial was only added to the index.rhtml file. This commit adds the footer partial to the other template files. * Remove unnecessary middle divs in nav * Simplify sidebar's overflow settings Because sidebar needs to be scrollable, its overflow should default to auto. Currently it's set to hidden and force individual elements to set overflow auto, which overcomplicates things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nav's height not properly constrained. Addingbottom: 0fixes it.bodybut displaying it only innav, while wanting to make it adjustable for scrolling, has been proven problematic. So I decided to move thefooterelement insidenavand do the corresponding css adjustments for it.The demo below shows that the sidebar's content is now scrollable again, with the footer stick to the bottom while sidebar is being scrolled.
Screen.Recording.2024-08-09.at.23.02.37.mov