Use frozen_string_literal: true #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on #550 for that CI passes tests. |
aycabta
force-pushed
the
use-frozen_string_literal-true
branch
from
ef82462 to
4b28219
Compare
|
Please wait to merge, I forgot to add magic comment to *.ry and *.kpeg. |
|
Please merge #560 first. |
|
Added |
aycabta
force-pushed
the
use-frozen_string_literal-true
branch
from
b0e5adb to
498f24c
Compare
|
I'm sorry, rebased. |
|
I will merge this after merging #556 and rebased. |
aycabta
force-pushed
the
use-frozen_string_literal-true
branch
from
498f24c to
d7db5f4
Compare
Ruby 2.2 or earlier only has String#force_encoding for changing character encoding set without encode byte sequence, it changes receiver itself. Ruby 2.3 or later has frozen_striing_literal magic comment and String#new can take encoding keyword parameter for character encoding set without encode byte sequence. So implements RDoc::Encoding.change_encoding and RDoc::Comment#encode! to disguise difference between #force_encoding and encoding keyword parameter of #new on String.
aycabta
force-pushed
the
use-frozen_string_literal-true
branch
from
d7db5f4 to
8ffc114
Compare
|
LGTM. Note: I confirmed to update some assertions on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
frozen_string_literal: true.Ruby 2.2 or earlier only has
String#force_encodingfor changing character encoding set without encode byte sequence, it changes receiver itself. Ruby 2.3 or later hasfrozen_striing_literalmagic comment andString#newcan take encoding keyword parameter for character encoding set without encode byte sequence.So implements
RDoc::Encoding.change_encodingandRDoc::Comment#encode!to disguise difference between#force_encodingand encoding keyword parameter of#newonString.This Pull Request changes output of table_of_contents.html, but #549 conforms output to the same output.