Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --dry-run option #556

Merged
merged 3 commits into from
Nov 27, 2017
Merged

Fix --dry-run option #556

merged 3 commits into from
Nov 27, 2017

Conversation

aycabta
Copy link
Member

@aycabta aycabta commented Nov 11, 2017

This fixes #357.

rdoc = RDoc::RDoc.new

temp_dir do
capture_io do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm any assertions? We should assert that has no error or not generate rdoc files.

rdoc.document options
end

refute File.directory? 'doc'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hsbt hsbt merged commit d9529ad into ruby:master Nov 27, 2017
@aycabta aycabta deleted the fix-dry-run branch November 27, 2017 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

rdoc + darkfish + dry-run aborts
2 participants