Prevent unnecessary doubled loading of environment variables #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjlarose
force-pushed
the
remove-redundant-load-env
branch
from
fe896db to
b1e6b5a
Compare
pkuczynski
changed the title
ippachi
pushed a commit
to ippachi/config-1
that referenced
this pull request
Oct 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
Config.load_filesends up reading environment variables and setting them in theOptionsobject twice.Config.load_filescallsOptions#load!(an alias forOptions#reload!), which callsOptions#reload_env!.Then
Config.load_filesimmediately callsOptions#load_env!, which is just an alias forOptions#reload_env!.Since
Options#reload_env!is idempotent, I can't imagine this being necessary or desirable. This redundancy has present since support for overriding settings with environment variables was introduced in #64.