Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unnecessary doubled loading of environment variables #291

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Prevent unnecessary doubled loading of environment variables #291

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1e6b5a
Remove redundant call to Options#load_env
cjlarose Nov 26, 2020
5695d93
Update CHANGELOG.md
pkuczynski Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Bug fixes

* Added alias to_h for to_hash ([#277](https://github.com/railsconfig/config/issues/277))
* Stop double-loading environment variables unnecessarily ([#291](https://github.com/rubyconfig/config/pull/291))

### Changes

Expand Down
1 change: 0 additions & 1 deletion lib/config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ def self.load_files(*files)
end

config.load!
config.load_env! if use_env
config
end

Expand Down