addressed comments

rudderlabs · Mar 14, 2024 · eb8c236 · eb8c236
1 parent c94723d
commit eb8c236
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/testhelper/docker/resource/transformer/transformer.go b/testhelper/docker/resource/transformer/transformer.go
@@ -8,7 +8,7 @@ import (
 
 	"github.com/samber/lo"
 
-	dockerTestHelper "github.com/rudderlabs/rudder-go-kit/testhelper/docker"
+	dockertesthelper "github.com/rudderlabs/rudder-go-kit/testhelper/docker"
 
 	"github.com/ory/dockertest/v3"
 	"github.com/ory/dockertest/v3/docker"
@@ -58,7 +58,7 @@ func WithUserTransformations(transformations map[string]string, cleaner resource
 	return func(conf *config) {
 		backendConfigSvc := newTestBackendConfigServer(transformations)
 
-		conf.setBackendConfigURL(dockerTestHelper.ToInternalDockerHost(backendConfigSvc.URL))
+		conf.setBackendConfigURL(dockertesthelper.ToInternalDockerHost(backendConfigSvc.URL))
 		conf.extraHosts = append(conf.extraHosts, "host.docker.internal:host-gateway")
 		cleaner.Cleanup(func() {
 			backendConfigSvc.Close()
@@ -78,7 +78,7 @@ func WithConnectionToHostEnabled() func(*config) {
 // WithConfigBackendURL should not be used with WithUserTransformations option
 func WithConfigBackendURL(url string) func(*config) {
 	return func(conf *config) {
-		conf.setBackendConfigURL(dockerTestHelper.ToInternalDockerHost(url))
+		conf.setBackendConfigURL(dockertesthelper.ToInternalDockerHost(url))
 	}
 }
 

diff --git a/testhelper/httptest/httptest_test.go b/testhelper/httptest/httptest_test.go
@@ -58,7 +58,7 @@ func TestUnStartedServer(t *testing.T) {
 		resp, err := http.Get("http://" + httpUnStartedServer.Listener.Addr().String())
 		defer func() { httputil.CloseResponse(resp) }()
 		return err == nil
-	}, 5*time.Second, time.Second, "connected to an un-started server")
+	}, 5*time.Second, 10*time.Millisecond, "connected to an un-started server")
 
 	// start the server now
 	httpUnStartedServer.Start()
@@ -72,7 +72,7 @@ func TestUnStartedServer(t *testing.T) {
 			body, err = io.ReadAll(resp.Body)
 		}
 		return err == nil
-	}, 5*time.Second, time.Second, "failed to connect to server")
+	}, 2*time.Second, 100*time.Millisecond, "failed to connect to server")
 
 	require.Equal(t, http.StatusOK, statusCode)
 	require.Equal(t, "Hello, world!", string(body))