fix: docker containers don't listen to host.docker.internal #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
requested review from
debanjan97,
lvrach,
fracasula,
mihir20 and
achettyiitr
achettyiitr
approved these changes
Aug 30, 2024
atzoum
changed the title
debanjan97
approved these changes
Aug 30, 2024
Merged
mihir20
reviewed
Aug 30, 2024
| @@ -4,7 +4,7 @@ import ( | |||
| "github.com/ory/dockertest/v3/docker" | |||
| ) | |||
|
|
|||
| const BindHostIP = "127.0.0.1" | |||
| const BindHostIP = "0.0.0.0" | |||
There was a problem hiding this comment.
0.0.0.0 would be corresponding to all the interfaces(including IPV6), we can introduce a new ip for 172.17.0.1
There was a problem hiding this comment.
host.docker.internal doesn't always resolve to the same ip...
There was a problem hiding this comment.
would something like this help? https://github.com/rudderlabs/rudder-go-kit/pull/615/files
There was a problem hiding this comment.
In case of Docker Desktop for Mac, this causes issues :(
API error (500): driver failed programming external connectivity on endpoint thirsty_napier (78e1f6fa6a0132e1f00cbadbb20ef86b89d7cdc55ddd6828c0eb7bbc9516d67a): failed to bind port 127.0.0.1:55053/tcp: listen tcp4 127.0.0.1:55053: bind: address already in use
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
host.docker.internalin linux, by default, resolves to172.17.0.1Security