Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker containers listening on ipv6 #616

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: docker containers listening on ipv6 #616

merged 1 commit into from
Aug 30, 2024

Conversation

atzoum
Copy link
Collaborator

@atzoum atzoum commented Aug 30, 2024 •
edited
Loading

Description

Binding only to 127.0.0.1 (and host.docker.internal in case of linux)

regression introduced by #614

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@atzoum atzoum changed the title [WIP] fix: docker containers listening on ipv6 fix: docker containers listening on ipv6 Aug 30, 2024
@atzoum atzoum mentioned this pull request Aug 30, 2024
Merged
1 task
@lvrach
Copy link
Member

lvrach commented Aug 30, 2024

I was under the impression, I had set it to 127.0.0.1 :/ my bad, thanks for fixing

mihir20
mihir20 approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atzoum atzoum merged commit 76a6758 into main Aug 30, 2024
12 checks passed
@atzoum atzoum deleted the fix.bindhostip branch August 30, 2024 11:04
@devops-github-rudderstack devops-github-rudderstack mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihir20 mihir20 mihir20 approved these changes

@debanjan97 debanjan97 debanjan97 approved these changes

@lvrach lvrach lvrach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atzoum @lvrach @debanjan97 @mihir20