web: Properly panic when loading invalid SWF files (fix #14665)

[danielhjacobs]

Note: The error when loading a page which is not an SWF is the same as the error when loading an SWF that does not exist for the purpose of code simplicity. This can be changed if desired.

[danielhjacobs]

#6665 is related, and the main point listed in that issue will now cause a panic. However, it's still true that other asynchronous errors just log without being able to be handled without some custom JavaScript, so this doesn't fully close that issue.

[Lord-McSweeney]

I think having the message be the same for invalid SWF vs SWF download fail is confusing, but I'm not sure how differentiating would be implemented- adding a new UI function feels like overkill.

[danielhjacobs]

I think having the message be the same for invalid SWF vs SWF download fail is confusing, but I'm not sure how differentiating would be implemented- adding a new UI function feels like overkill.

Maybe this can take a boolean parameter invalidSwf: boolean. All other places calling it can switch to display_root_movie_download_failed_message(false)

ruffle/web/packages/core/src/ruffle-player.ts

Line 2244 in 3c11523

protected displayRootMovieDownloadFailedMessage(): void {

Then before these lines:

ruffle/web/packages/core/src/ruffle-player.ts

Lines 2277 to 2281 in 1b5eb2e

	} else if (
	window.location.origin === this.swfUrl!.origin ||
	// The extension's internal player page is not restricted by CORS
	window.location.protocol.includes("extension")
	) {

I can add this:

} else if (invalidSwf) {
    error.ruffleIndexError = PanicError.InvalidSwf;

And before this line:

ruffle/web/packages/core/src/ruffle-player.ts

Line 38 in 1b5eb2e

SwfFetchError,

I can add InvalidSwf,

And before this:

ruffle/web/packages/core/src/ruffle-player.ts

Line 2114 in 1b5eb2e

case PanicError.SwfFetchError:

I can add:

            case PanicError.InvalidSwf:
                errorBody = textAsParagraphs("error-invalid-swf");
                errorFooter = this.createErrorFooter([new PanicLinkInfo()]);
                break;

And then I can add a message for error-invalid-swf before this:

ruffle/web/packages/core/texts/en-US/messages.ftl

Lines 33 to 36 in 1b5eb2e

	error-swf-fetch =
	Ruffle failed to load the Flash SWF file.
	The most likely reason is that the file no longer exists, so there is nothing for Ruffle to load.
	Try contacting the website administrator for help.

[danielhjacobs]

I thought of all that before making this PR, which is why my initial comment said I did it the way I did "for the purpose of code simplicity."

[danielhjacobs]

My new commit adds a message for invalid SWF files separate from the message for non-existent files and displays it in all appropriate situations (loading an existing non-SWF file via URL and loading an existing non-SWF file using the file selector).