Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: Bump wasm-bindgen to 0.2.83 #8057

Merged
merged 1 commit into from
Sep 23, 2022
Merged

web: Bump wasm-bindgen to 0.2.83 #8057

merged 1 commit into from
Sep 23, 2022

Conversation

relrelb
Copy link
Contributor

@relrelb relrelb commented Sep 23, 2022

This reverts commit cf721d4 and restores commit 084b252, this time without updating web-sys, due to being coupled to wgpu.

@relrelb relrelb changed the title web: Bump wasm-bindgen to 0.2.83` web: Bump wasm-bindgen to 0.2.83 Sep 23, 2022
@relrelb
web: Bump wasm-bindgen to 0.2.83
e924962 
This reverts commit cf721d4 and restores
commit 084b252, this time without updating
`web-sys`, due to being coupled to `wgpu`.
@danielhjacobs
Copy link
Contributor

Do we know why #7971 passed CI, only to fail in the nightly? Is there some way the test workflows could be changed to test for the issue that the nightly build failed on, or is that just not possible to test in advance?

@danielhjacobs
Copy link
Contributor

Also worth noting wgpu version 14 is slated for September 28th according to https://github.com/gfx-rs/wgpu/milestone/15 and gfx-rs/wgpu#2954 has been merged, so assuming there is no issue with updating Ruffle to that version, web-sys can probably be bumped alongside that in less than a week.

@relrelb
Copy link
Contributor Author

relrelb commented Sep 23, 2022

Do we know why #7971 passed CI, only to fail in the nightly? Is there some way the test workflows could be changed to test for the issue that the nightly build failed on, or is that just not possible to test in advance?

Good point; I'm not sure. I think it's because test_web.yml defines CARGO_FLAGS=--all-features, whereas release_nightly.yml defines CARGO_FEATURES=webgpu. Thus the former enables both webgpu and wgpu-webgl, but the latter only webgpu. So I guess wgpu-webgl actually hides the failure, as it prevents the erroneous code from being compiled-in.

@Dinnerbone Can you please confirm?

@relrelb relrelb merged commit 1954f61 into ruffle-rs:master Sep 23, 2022
@relrelb relrelb deleted the wasm_bindgen branch September 23, 2022 14:23
@danielhjacobs
Copy link
Contributor

danielhjacobs commented Sep 24, 2022 •
edited
Loading

Tonight's release failed again: https://github.com/ruffle-rs/ruffle/actions/runs/3116357863/jobs/5054101641

@relrelb relrelb mentioned this pull request Sep 24, 2022
Merged
@relrelb
Copy link
Contributor Author

relrelb commented Sep 24, 2022

Tonight's release failed again: https://github.com/ruffle-rs/ruffle/actions/runs/3116357863/jobs/5054101641

Oh well, I guess we'll have to wait for the next wgpu release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@relrelb @danielhjacobs