core: Use BitmapData instead of separate initial_data field
#9143
Conversation
|
This change does reduce memory use from 5 to 2-3 GB in ruffle_desktop, but unfortunately it still goes above 4GB in any web browser, meaning #9137 does not get fixed. |
Actually, although this PR does not fix Cascade on its own, it DOES fix Cascade when merged with #9134 (memory usage is 3GB on web with both PRs merged). So I guess... either the optimizations of this PR don't apply to the webgl renderer for some reason; or else the wgpu renderer happens to have a lower memory footprint for unrelated reasons, and both optimizations combined are enough to bring cascade under the 4GB limit. |
Now that a `Bitmap` always stores a `BitmapData`, we can read the pixels directly from the `BitmapData`, instead of duplicating them in an `initial_data` field
Aaron1011
force-pushed
the
no-initial-data
branch
from
0d31da7 to
bfc6e8c
Compare
Since `initial_data` was removed from `Character::Bitmap` in ruffle-rs#9143, it now holds a single field. Move back to an unnamed field, which aligns with the other `Character` enum variants.
Since `initial_data` was removed from `Character::Bitmap` in #9143, it now holds a single field. Move back to an unnamed field, which aligns with the other `Character` enum variants.
Now that a
Bitmapalways stores aBitmapData, we can read the pixels directly from theBitmapData, instead of duplicating them in aninitial_datafield