Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report failures communicating with VCS on PR. #398

Closed
rsalmond opened this issue Dec 18, 2018 · 1 comment
Closed

Report failures communicating with VCS on PR. #398

rsalmond opened this issue Dec 18, 2018 · 1 comment
Labels
feature New functionality/enhancement

Comments

@rsalmond
Copy link

After atlantis reported a clean looking successful plan on the PR user issued at atlantis apply command and received no feedback on the PR. Examination of logs revealed this.

[atlantis-779f7554b7-xqvm4] 2018/12/18 16:45:21 [INFO] server: Parsed comment as command="apply" verbose=false dir="" workspace="" project="" flags=""
[atlantis-779f7554b7-xqvm4] 2018/12/18 16:45:21 [INFO] server: 200 | POST /events
[atlantis-779f7554b7-xqvm4] 2018/12/18 16:45:22 [ERROR] <our_org>/<our_repo>#853: Making pull request API call to GitHub: GET https://api.github.com/repos/<our_org>/<our_repo>/pulls/853: 502 Server Error []

Looked like it was just a transient error in the Github API. Would be nice if atlantis either reported this back on the PR or even better went into a backoff-retry phase before giving up and reporting an issue.
@lkysow lkysow mentioned this issue Dec 19, 2018
Merged
@lkysow
Copy link
Member

lkysow commented Dec 19, 2018

Ack, yeah we should at least write a comment in that case.

I think retries might be nice but because this shouldn't happen too often I'm not sure it's worth the additional complexity.

lkysow added a commit that referenced this issue Dec 19, 2018
@lkysow
Write error comment on early failures.
68ac049 
Previously, we were just logging when an error happened early in our
comment processing code. However it's possible for us to write comments
on error even at this early stage which will make for a better user
experience.

Fixes #398
@lkysow lkysow added bug Something isn't working feature New functionality/enhancement and removed bug Something isn't working labels Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New functionality/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lkysow @rsalmond