Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write error comment on early failures. #401

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Write error comment on early failures. #401

merged 1 commit into from
Dec 19, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Dec 19, 2018

Previously, we were just logging when an error happened early in our
comment processing code. However it's possible for us to write comments
on error even at this early stage which will make for a better user
experience.

Fixes #398

Previously, we were just logging when an error happened early in our
comment processing code. However it's possible for us to write comments
on error even at this early stage which will make for a better user
experience.

Fixes #398
@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #401 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   69.88%   69.84%   -0.04%     
==========================================
  Files          62       62              
  Lines        3815     3817       +2     
==========================================
  Hits         2666     2666              
- Misses        960      961       +1     
- Partials      189      190       +1
Impacted Files Coverage Δ
server/events/command_runner.go 71.32% <0%> (-1.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84289ea...68ac049. Read the comment docs.

@lkysow lkysow merged commit 2b4f3f3 into master Dec 19, 2018
@lkysow lkysow deleted the comment-on-failure branch December 19, 2018 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant